PHP Developers Network

A community of PHP developers offering assistance, advice, discussion, and friendship.
 
Loading
It is currently Thu Nov 27, 2014 12:04 pm

All times are UTC - 5 hours




Post new topic Reply to topic  [ 44 posts ]  Go to page Previous  1, 2, 3  Next
Author Message
 Post subject: Re: PHP Code tags
PostPosted: Sun Jan 13, 2008 11:43 am 
Offline
Moderator
User avatar

Joined: Mon Nov 03, 2003 7:13 pm
Posts: 5921
Location: Odessa, Ukraine
Syntax: [ Download ] [ Hide ]
 
function something() {};
 

:
Image

:evil:


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Sun Jan 13, 2008 12:15 pm 
Offline
Site Administrator
User avatar

Joined: Tue Sep 09, 2003 6:04 pm
Posts: 14293
Location: Fremont, CA, USA
The plugin we are using is very specific to proSilver from what I understand. I think the priority was on getting the tags to parse first with the CSS tweaks coming later. I also know that the CSS was being worked on for subSilver and that the proSilver tweaks had not yet been implemented.


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Sun Jan 13, 2008 12:32 pm 
Offline
DevNet Master
User avatar

Joined: Wed Dec 06, 2006 5:14 pm
Posts: 3635
Location: Toronto, Canada
Wow - I've forced a refresh several times and still no joy :-(

FF on Gutsy.


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Sun Jan 13, 2008 1:01 pm 
Offline
Site Administrator
User avatar

Joined: Tue Sep 09, 2003 6:04 pm
Posts: 14293
Location: Fremont, CA, USA
In subSilver or proSilver?


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Sun Jan 13, 2008 1:13 pm 
Offline
DevNet Master
User avatar

Joined: Wed Dec 06, 2006 5:14 pm
Posts: 3635
Location: Toronto, Canada
proSilver


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Sun Jan 13, 2008 2:53 pm 
Offline
Moderator
User avatar

Joined: Mon Nov 03, 2003 7:13 pm
Posts: 5921
Location: Odessa, Ukraine
Kieran Huggins wrote:
proSilver

proSilver has not been tweaked from what I see (though 'Collapse / Turn line numbers off / Select all' links started working)


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Sun Jan 13, 2008 4:52 pm 
Offline
Breakbeat Nuttzer
User avatar

Joined: Wed Mar 24, 2004 8:57 am
Posts: 13098
Location: Melbourne, Australia
Because I'm not a forum admin I've been unable to edit the templates in proslver (editting the files doesn't change anything -- it's go do be done in the admin panel's editor!).

It will be fixed today ;)


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Mon Jan 14, 2008 3:56 am 
Offline
Breakbeat Nuttzer
User avatar

Joined: Wed Mar 24, 2004 8:57 am
Posts: 13098
Location: Melbourne, Australia
For anyone using the proSilver theme, you may have noticed that the code blocks have been looking screwy. If you log out and back in again you should see everything as normal now (phpBB caches styles in the session I think).


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Mon Jan 14, 2008 4:35 am 
Offline
DevNet Master
User avatar

Joined: Wed Dec 06, 2006 5:14 pm
Posts: 3635
Location: Toronto, Canada
Chris Corbyn wrote:
phpBB caches styles in the session I think.

THAT was the ticket - thanks Chris!!

Why is BBCode off now?


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Mon Jan 14, 2008 4:39 am 
Offline
Admin
User avatar

Joined: Wed Aug 13, 2003 7:02 am
Posts: 4522
Location: York, UK
Kieran Huggins wrote:
Why is BBCode off now?


You had the "Disable BBCode" checkbox selected.


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Mon Jan 14, 2008 4:37 pm 
Offline
DevNet Master

Joined: Thu Oct 06, 2005 3:57 pm
Posts: 3360
The new php code tags are horrible. The functionality is nice, but the code is very, very hard to look at. Bad font, distracting line-numbers and background horizontal bands. Too little contrast in colors. Using subsilver by the way. Am I the only one?


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Mon Jan 14, 2008 6:13 pm 
Offline
Breakbeat Nuttzer
User avatar

Joined: Wed Mar 24, 2004 8:57 am
Posts: 13098
Location: Melbourne, Australia
matthijs wrote:
The new php code tags are horrible. The functionality is nice, but the code is very, very hard to look at. Bad font, distracting line-numbers and background horizontal bands. Too little contrast in colors. Using subsilver by the way. Am I the only one?


The colors are the default geshi ones. We fixed that up last time we installed a GeSHi mod ;) We'll do it again here. There are lots of things going on to get this new forum up, running and stable so just bear with us :)

The font size is going to be improved and the line numbers will be hacked to be off by default.


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Tue Jan 15, 2008 12:53 am 
Offline
DevNet Master

Joined: Thu Oct 06, 2005 3:57 pm
Posts: 3360
Ok, good to hear that. I was just afraid that it would stay like that.

My suggestions: (if not superfluous):
- bigger font-size
- the old colors (green etc)
- other font-family (don't know what it used to be?)
- ditch the row background colors, doesn't add anything, only distracts

p.s. all the hard work you mods do on the new forum is appreciated


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Tue Jan 15, 2008 4:18 am 
Offline
DevNet Master
User avatar

Joined: Wed Dec 06, 2006 5:14 pm
Posts: 3635
Location: Toronto, Canada
I, for one, love the new code boxes (boxen?) I vote to keep them. The zebra striping is actually quite useful, IMO.

Maybe it will grow on the others? Change is often like that.


Top
 Profile  
 
 Post subject: Re: PHP Code tags
PostPosted: Tue Jan 15, 2008 5:29 am 
Offline
DevNet Master
User avatar

Joined: Wed Jun 27, 2007 9:44 am
Posts: 4294
Location: Sofia, Bulgaria
Honestly, I dislike the scroll bars in the code blocks - first, I can't see the whole code and second, it makes me angry when I want to scroll the page with the mouse wheel.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 44 posts ]  Go to page Previous  1, 2, 3  Next

All times are UTC - 5 hours


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB® Forum Software © phpBB Group