PHP Code tags

[Kieran Huggins]

maybe have the expand / contract button open them to full-height instead of closing them? So toggle between a max-height and unrestricted?

[John Cartwright]

maybe have the expand / contract button open them to full-height instead of closing them? So toggle between a max-height and unrestricted?

Indeed. The scroll bar is a bit annoying on any decent resolution since your so limited the amount of code viewable..

[Christopher]

I agree and was just thinking the same thing.

[VladSun]

maybe have the expand / contract button open them to full-height instead of closing them? So toggle between a max-height and unrestricted?

Then how about adding a default view of it in the User control panel

[Chris Corbyn]

Sheesh! All this hacking to do on someone else's code....

/me agrees with everything said...

[matthijs]

Ok, I found out what has to be done about the code blogs: remove the font-family:monospace; It looks illegible. Removing that brings back my beloved font-family Lucida grande as the font used for the code blocks.

[Chris Corbyn]

Ok, I found out what has to be done about the code blogs: remove the font-family:monospace; It looks illegible. Removing that brings back my beloved font-family Lucida grande as the font used for the code blocks.

I'm actually messing around with the syntax tags right now and have just tried what you said. Although it may work nicely with your browser settings, in my FF and in Safari I end up with a non-monospaced font (same as the page maybe?):

Syntax: [ Download ] [ Hide ]

Syntax: [ Download ] [ Show ]

class Foo {
  function bar($x) {
    for ($i = 0; $i < $x; $i++) {
      //something
    }
  }
}

Unfortunately to see the changes on other posts they need to be editted and resubmitted due to the way the BBCode works.

[matthijs]

Yes, I also end up with the non-monospaced font, Lucida grande in my case

Syntax: [ Download ] [ Hide ]

Syntax: [ Download ] [ Show ]

stylesheet.css (line 242)
.postbody {
font-family:"Lucida Grande","Trebuchet MS",Helvetica,Arial,sans-serif;
font-size:1.3em;
line-height:1.4em;
}

That's much better.

Should it be mono-space? I also noticed that increasing the font-size a bit also helped a lot.

[Weirdan]

Should it be mono-space? I also noticed that increasing the font-size a bit also helped a lot.

Are you joking? The code should be displayed in a monospace font, that's for sure. Otherwise all code formatting will go wild. Or were you talking about something else?

[matthijs]

No, I wasn't joking :)

Then just a text-size increase of .1em or something for the code will do the trick. I live-edited the styles for the code block and .1 or .2 was enough to make a big difference. Of course, how something looks will depend on someone's system, so it can never be perfect for everybody. But if code text is tiny for me, having good eyesight, I'm sure more people would appreciate a tiny bit bigger.

But again, the moderators will have to decide what's best, this is just my feedback.

[JayBird]

matthijs: are you saying it should or shouldn't be monospaced!?

I'm confused

[RobertGonzalez]

I think it should be monospace (perhaps even Courier or Courier New) and I think it should be at 9pt. If a fixed size is not appropriate then maybe we can use a relative size compared to the board defaults.

[Weirdan]

If a fixed size is not appropriate then maybe we can use a relative size compared to the board defaults.

relative sizes ftw!

[matthijs]

matthijs: are you saying it should or shouldn't be monospaced!?

I'm confused :|

Sorry, I wasn't clear. I just noticed that removing the monospace font, and thereby having a non-monospaced font render the text, made it a lot more readable. But, I didn't think about the spacing issue. A monospace font is, of course, better for code fomatting.

Then the next best thing to do to improve the legibility is to increase the font-size a bit. I know I can do that myself by ctrl+ / cmnd +, but it's annoying to do that for every visit. And besides that, it's not the font-size of the board itself, only the font-size of the code blocks that's too small. In my humble opinion, that is (and for my specific system. But that's a default Mac setting, so wouldn't be too uncommon in the population visiting this forum).